Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement interactive-tx construction #349

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Implement interactive-tx construction #349

merged 1 commit into from
Aug 29, 2022

Conversation

t-bast
Copy link
Member

@t-bast t-bast commented Aug 24, 2022

We implement the protocol described in the dual funding specification (see lightning/bolts#851) to collaboratively create a shared transaction.

We don't support yet funding and signing such transactions, this will be added in future PRs once we have basic on-chain wallet support.

This is safe to merge as this code isn't called yet, except in tests.

We implement the protocol described in the dual funding specification
(see lightning/bolts#851) to collaboratively
create a shared transaction.

We don't support yet funding and signing such transactions.
@t-bast t-bast requested review from sstone and pm47 August 24, 2022 09:43
Copy link
Member

@pm47 pm47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a cursory review but the code isn't yet used and it looks like a closed port of the scala version.

@t-bast t-bast merged commit d274b69 into master Aug 29, 2022
@t-bast t-bast deleted the interactive-tx branch August 29, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants